Skip to content

chore(claude): add vhs permissions to allow and deny lists#424

Merged
zimeg merged 2 commits intomainfrom
zimeg-chore-claude-vhs-permissions
Mar 20, 2026
Merged

chore(claude): add vhs permissions to allow and deny lists#424
zimeg merged 2 commits intomainfrom
zimeg-chore-claude-vhs-permissions

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Mar 20, 2026

Changelog

N/A 👾

Summary

This PR adds vhs permissions to the @claude settings allow and deny lists for improved recordings 🎥 ✨

Requirements

@zimeg zimeg added this to the Next Release milestone Mar 20, 2026
@zimeg zimeg self-assigned this Mar 20, 2026
@zimeg zimeg requested a review from a team as a code owner March 20, 2026 05:07
@zimeg zimeg added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Mar 20, 2026
Copy link
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗣️ Rambling again for the amazing readers-

"Bash(make build:*)",
"Bash(make lint:*)",
"Bash(make test:*)",
"Bash(mkdir:*)",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪬 note: This is used for the demos paths if these don't exist.

"Bash(make test:*)",
"Bash(mkdir:*)",
"Bash(tree:*)",
"Bash(vhs:*)",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 note: Here're the current commands available!

  help        Help about any command
  new         Create a new tape file with example tape file contents and documentation
  publish     Publish your GIF to vhs.charm.sh and get a shareable URL
  record      Create a new tape file by recording your actions
  serve       Start the VHS SSH server
  themes      List all the available themes, one per line
  validate    Validate a glob file path and parses all the files to ensure they are valid without running them.

"WebFetch(domain:github.com)"
]
],
"deny": ["Bash(vhs publish:*)"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👹 note: We attempt to contain the machines for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Good call!

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.74%. Comparing base (050bae3) to head (6fd42d8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   69.75%   69.74%   -0.01%     
==========================================
  Files         220      220              
  Lines       18446    18446              
==========================================
- Hits        12867    12866       -1     
  Misses       4408     4408              
- Partials     1171     1172       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looking good! Perhaps you can give us a little demo of how you use this in Claude during our meeting today! 🎮

"WebFetch(domain:github.com)"
]
],
"deny": ["Bash(vhs publish:*)"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Good call!

@zimeg
Copy link
Member Author

zimeg commented Mar 20, 2026

@mwbrooks Thank you! I'd love to share walkthrough of example recordings whenever the right moment is 🐢

Thanks for reviewing this in the meantime. I look forward to upcoming PRs more and more! 🐙 ✨

@zimeg zimeg enabled auto-merge (squash) March 20, 2026 21:29
@zimeg zimeg merged commit c20760d into main Mar 20, 2026
7 checks passed
@zimeg zimeg deleted the zimeg-chore-claude-vhs-permissions branch March 20, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants