Skip to content

ci: skip artifact creation for upstream testing for forks#44

Closed
zimeg wants to merge 8 commits intoslackapi:mainfrom
zimeg:ci-skip-fork-prereleases
Closed

ci: skip artifact creation for upstream testing for forks#44
zimeg wants to merge 8 commits intoslackapi:mainfrom
zimeg:ci-skip-fork-prereleases

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Apr 17, 2025

Summary

This PR skips artifact creation and E2E tests for PRs created from forked branches. Workaround for edges of git in CI.

Notes

  • The "build-lint-test-e2e-test" workflow is required and can be started for forked PRs with these steps 📚
  • The "build-lint-test-e2e-test" workflow includes a step with goreleaser that is kept as a build test 👾

Requirements

@zimeg zimeg added semver:patch Use on pull requests to describe the release version increment build M-T: Changes to compilation and CI processes labels Apr 17, 2025
@zimeg zimeg added this to the Next Release milestone Apr 17, 2025
@zimeg zimeg self-assigned this Apr 17, 2025
@zimeg zimeg requested a review from a team as a code owner April 17, 2025 17:27
Copy link
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Link to related documentation and a note on the related change in a comment following-

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.93%. Comparing base (a1bcf9e) to head (5ed2f4f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   62.89%   62.93%   +0.03%     
==========================================
  Files         210      210              
  Lines       22147    22147              
==========================================
+ Hits        13930    13938       +8     
+ Misses       7129     7125       -4     
+ Partials     1088     1084       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM @zimeg! :shipit:

Comment on lines 519 to 521
filters:
branches:
ignore: "^pull\/.*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌🏻

@zimeg zimeg marked this pull request as draft April 18, 2025 00:18
@zimeg
Copy link
Member Author

zimeg commented Apr 18, 2025

@mwbrooks Thanks once more for the review on this testing saga 🤖

I'm closing this PR since we're finding that branches from a fork can still be tested with the right set of permissions. Or moreso skipped changes to the .github/workflows files.

@zimeg zimeg closed this Apr 18, 2025
@zimeg zimeg deleted the ci-skip-fork-prereleases branch April 18, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build M-T: Changes to compilation and CI processes semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants