ci: skip artifact creation for upstream testing for forks#44
Closed
zimeg wants to merge 8 commits intoslackapi:mainfrom
Closed
ci: skip artifact creation for upstream testing for forks#44zimeg wants to merge 8 commits intoslackapi:mainfrom
zimeg wants to merge 8 commits intoslackapi:mainfrom
Conversation
zimeg
commented
Apr 17, 2025
Member
Author
zimeg
left a comment
There was a problem hiding this comment.
📝 Link to related documentation and a note on the related change in a comment following-
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 62.89% 62.93% +0.03%
==========================================
Files 210 210
Lines 22147 22147
==========================================
+ Hits 13930 13938 +8
+ Misses 7129 7125 -4
+ Partials 1088 1084 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
approved these changes
Apr 17, 2025
.circleci/config.yml
Outdated
Comment on lines
519
to
521
| filters: | ||
| branches: | ||
| ignore: "^pull\/.*" |
2 tasks
Member
Author
|
@mwbrooks Thanks once more for the review on this testing saga 🤖 I'm closing this PR since we're finding that branches from a fork can still be tested with the right set of permissions. Or moreso skipped changes to the |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR skips artifact creation and E2E tests for PRs created from forked branches. Workaround for edges of
gitin CI.Notes
goreleaserthat is kept as abuildtest 👾Requirements