Skip to content

chore!: remove deprecated "platform-improvements" feedback survey name#465

Merged
zimeg merged 2 commits intomainfrom
zimeg-chore-remove-outdated-feedback-survey
Apr 7, 2026
Merged

chore!: remove deprecated "platform-improvements" feedback survey name#465
zimeg merged 2 commits intomainfrom
zimeg-chore-remove-outdated-feedback-survey

Conversation

@zimeg
Copy link
Copy Markdown
Member

@zimeg zimeg commented Apr 2, 2026

Changelog

We removed the deprecated platform-improvements survey name from the feedback command to now prefer the slack-platform name when providing Slack Platform feedback.

Summary

🪓 This PR removes the deprecated SlackPlatformFeedbackDeprecated constant and the backwards-compatibility mapping that redirected --name platform-improvements to --name slack-platform. Using the old name will now return an invalid feedback name error.

Requirements

@zimeg zimeg requested a review from a team as a code owner April 2, 2026 20:07
@zimeg zimeg added changelog Use on updates to be included in the release notes code health M-T: Test improvements and anything that improves code health semver:major Use on pull requests to describe the release version increment labels Apr 2, 2026
@zimeg zimeg self-assigned this Apr 2, 2026
@zimeg zimeg added this to the Next Release milestone Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.05%. Comparing base (5100c02) to head (591ae18).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
- Coverage   71.06%   71.05%   -0.02%     
==========================================
  Files         220      220              
  Lines       18522    18519       -3     
==========================================
- Hits        13163    13159       -4     
  Misses       4181     4181              
- Partials     1178     1179       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@srtaalej srtaalej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code health mhm ✅ ✅ ✅

@zimeg
Copy link
Copy Markdown
Member Author

zimeg commented Apr 7, 2026

@srtaalej It's nice to keep the maintained paths tested well! 🚢

@zimeg zimeg enabled auto-merge (squash) April 7, 2026 06:09
@zimeg zimeg merged commit 2927885 into main Apr 7, 2026
8 checks passed
@zimeg zimeg deleted the zimeg-chore-remove-outdated-feedback-survey branch April 7, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog Use on updates to be included in the release notes code health M-T: Test improvements and anything that improves code health semver:major Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants