Skip to content

fix: broken Content-MD5 header for S3 upload #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwbrooks merged 2 commits into from
May 7, 2026
+0 −13
Merged

fix: broken Content-MD5 header for S3 upload #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af9b7ca
fix: remove broken MD5 Content-MD5 header from S3 upload
mwbrooks May 7, 2026
e4ca14d
Merge branch 'main' into mwbrooks-snyk-fix-s3-md5
mwbrooks May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions internal/api/s3_upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ package api
import (
"bytes"
"context"
"crypto/md5"
"encoding/base64"
"fmt"
"io"
"mime/multipart"
Expand Down Expand Up @@ -76,13 +74,6 @@ func (c *Client) UploadPackageToS3(ctx context.Context, fs afero.Fs, appID strin
}
}

md5hash := md5.New()
if _, err := io.Copy(md5hash, archive); err != nil {
return fileName, err
}

md5s := base64.StdEncoding.EncodeToString(md5hash.Sum(nil))

var part io.Writer
h := make(textproto.MIMEHeader)
h.Set("Content-Disposition", fmt.Sprintf(`form-data; name="%s"; filename="%s"`, "file", fileName))
Expand All @@ -105,7 +96,6 @@ func (c *Client) UploadPackageToS3(ctx context.Context, fs afero.Fs, appID strin
return fileName, err
}
request.Header.Add("Content-Type", writer.FormDataContentType())
request.Header.Add("Content-MD5", md5s)
cliVersion, err := slackcontext.Version(ctx)
if err != nil {
return fileName, err
Expand Down
3 changes: 0 additions & 3 deletions internal/api/s3_upload_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,6 @@ func TestClient_UploadPackageToS3(t *testing.T) {
require.NoError(t, err)
require.Equal(t, "this is the package", string(contentBytes))

md5Header := r.Header["Content-Md5"][0]
require.Equal(t, "1B2M2Y8AsgTpgAmY7PhCfg==", md5Header)

w.WriteHeader(http.StatusNoContent)
}))
defer server.Close()
Expand Down
Loading