fix: disable upgrade notification for the api command#542
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
==========================================
+ Coverage 71.55% 71.59% +0.03%
==========================================
Files 224 224
Lines 18976 18976
==========================================
+ Hits 13578 13585 +7
+ Misses 4193 4191 -2
+ Partials 1205 1200 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Thanks for the super fast review @zimeg! 🙇🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
Adds
slack apito the list of ignored commands in the upgrade notification system.The
slack apicommand is intended for scripting and direct API calls, where upgrade notifications interfere with parsing the response output.Preview
Testing
go build -ldflags="-X 'github.com/slackapi/slack-cli/internal/version.Version=v1.0.0'" -o bin/slacklastUpdateCheckedAttimestamp from~/.slack/config.jsonso the check isn't skipped due to recency.slack apidoes NOT show an upgrade notification:Requirements