Skip to content

fix: disable upgrade notification for the api command#542

Merged
mwbrooks merged 1 commit into
mainfrom
mwbrooks-api-command-disable-upgrade
May 13, 2026
Merged

fix: disable upgrade notification for the api command#542
mwbrooks merged 1 commit into
mainfrom
mwbrooks-api-command-disable-upgrade

Conversation

@mwbrooks
Copy link
Copy Markdown
Member

@mwbrooks mwbrooks commented May 13, 2026

Changelog

The slack api command no longer displays CLI upgrade notifications. The slack api command is intended for scripting and direct API calls, where upgrade notifications interfere with parsing the response output.

Summary

Adds slack api to the list of ignored commands in the upgrade notification system.

The slack api command is intended for scripting and direct API calls, where upgrade notifications interfere with parsing the response output.

Preview

  • N/A

Testing

  1. Build with an artificially old version to trigger the upgrade notification:
    go build -ldflags="-X 'github.com/slackapi/slack-cli/internal/version.Version=v1.0.0'" -o bin/slack
  2. Delete the lastUpdateCheckedAt timestamp from ~/.slack/config.json so the check isn't skipped due to recency.
  3. Verify slack api does NOT show an upgrade notification:
    ./bin/slack api apps.connections.open --token xoxb-fake
  4. Verify another command DOES show the upgrade notification.
    ./bin/slack auth list

Requirements

@mwbrooks mwbrooks self-assigned this May 13, 2026
@mwbrooks mwbrooks added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment labels May 13, 2026
@mwbrooks mwbrooks added this to the Next Release milestone May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.59%. Comparing base (bef3a23) to head (792be86).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
+ Coverage   71.55%   71.59%   +0.03%     
==========================================
  Files         224      224              
  Lines       18976    18976              
==========================================
+ Hits        13578    13585       +7     
+ Misses       4193     4191       -2     
+ Partials     1205     1200       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks marked this pull request as ready for review May 13, 2026 21:21
@mwbrooks mwbrooks requested a review from a team as a code owner May 13, 2026 21:21
Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks A peculiar improvement! 🌠

@mwbrooks
Copy link
Copy Markdown
Member Author

Thanks for the super fast review @zimeg! 🙇🏻

@mwbrooks mwbrooks merged commit f2e54bc into main May 13, 2026
10 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-api-command-disable-upgrade branch May 13, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants