Skip to content

build: remove paths to outdated artifacts in makefile clean#59

Merged
zimeg merged 3 commits into
mainfrom
zimeg-build-makefile-clean
Apr 22, 2025
Merged

build: remove paths to outdated artifacts in makefile clean#59
zimeg merged 3 commits into
mainfrom
zimeg-build-makefile-clean

Conversation

@zimeg
Copy link
Copy Markdown
Member

@zimeg zimeg commented Apr 22, 2025

Summary

This PR removes references to outdated build artifacts and confusing comments from outputs of make commands.

Preview

  $ make build
  golangci-lint run
  0 issues.
- rm -f ./slack
- rm -f ./slack-cli
- rm -f ./hermes
  rm -rf ./bin/
  rm -rf ./dist/
  mkdir bin/
- # set version using the latest tag plus short revision
  go build -ldflags="-X 'github.com/slackapi/slack-cli/internal/pkg/version.Version=`git describe --tags --match 'v*.*.*'`'" -o bin/slack
  SLACK_DISABLE_TELEMETRY="true" ./bin/slack version --skip-update
  Using slack v3.0.5-6-g7656d42

Requirements

@zimeg zimeg added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment build M-T: Changes to compilation and CI processes labels Apr 22, 2025
@zimeg zimeg added this to the Next Release milestone Apr 22, 2025
@zimeg zimeg self-assigned this Apr 22, 2025
@zimeg zimeg requested a review from a team as a code owner April 22, 2025 01:24
Copy link
Copy Markdown
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Methods to some of the madness, for the most kind reviewers!

Comment thread Makefile
# Initialize project
.PHONY: init
init:
# Get the latest tags to build correctly
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I understand how this is useful, but in outputs it might be confused as a TODO

Some notation exists to "stub" commands in a Makefile but I opted to delete this one instead for now 🪓

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.90%. Comparing base (b91c571) to head (ca20486).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   62.89%   62.90%           
=======================================
  Files         210      210           
  Lines       22156    22156           
=======================================
+ Hits        13936    13937    +1     
- Misses       7132     7133    +1     
+ Partials     1088     1086    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Love this change and I'm glad to see that we're taking the time to clean up the past iterations of the project!

@zimeg
Copy link
Copy Markdown
Member Author

zimeg commented Apr 22, 2025

@mwbrooks The iterations have been so fun to follow but I am glad we are now moving towards the latest 🌚

@zimeg zimeg merged commit 294f4fc into main Apr 22, 2025
6 checks passed
@zimeg zimeg deleted the zimeg-build-makefile-clean branch April 22, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build M-T: Changes to compilation and CI processes code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants