ENH: Adds Support for Formula Curves + Formula Editor #161
Merged
Conversation
zdomke
approved these changes
Aug 7, 2025
zdomke
left a comment
zdomke
left a comment
Collaborator
There was a problem hiding this comment.
PR looks good. The functionality is there and it works for the most part. There are some things that could be changed like functions that don't ever seem to be used.
The only issues that we really need to fix are mean, ln, and ^ being marked as invalid func names in the validation step.
The rest of these issues would be nice to haves or things we can get back to later.
Merged
Collaborator
|
You may need to rebase your branch or change the target branch since |
Collaborator
|
Looks good 👍 |
… formula curves. Made a slew of changes to get formula curves working. also fixed an issue with deleting curves. Made changes to how variable names are generated and added in an invalid symbol when a formula is no longer valid.
Co-authored-by: Zach Domke <102621345+zdomke@users.noreply.github.com>
Co-authored-by: Zach Domke <102621345+zdomke@users.noreply.github.com>
Co-authored-by: Zach Domke <102621345+zdomke@users.noreply.github.com>
Co-authored-by: Zach Domke <102621345+zdomke@users.noreply.github.com>
Co-authored-by: Zach Domke <102621345+zdomke@users.noreply.github.com>
Co-authored-by: Zach Domke <102621345+zdomke@users.noreply.github.com>
Co-authored-by: Zach Domke <102621345+zdomke@users.noreply.github.com>
…ore valid expression to the validator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Formula Curves + Formula Editor
this pr also adds in a utilities file formula_validation.py which has helper functions to validate formulas in the control panel
Note:
to test this you need to be on this branch of PyDM: slaclab/pydm#1260
Work still needed on this before merging in:
screenshots