Promote to production: onet connecting line fix - #307
Merged
Conversation
The line was drawn but invisible: strokeWidth 0.14 combined with vectorEffect='non-scaling-stroke' meant 0.14 SCREEN pixels, not 0.14 cells. The overlay was also mispositioned — its hand-picked -8%/116% offsets didn't match the viewBox (8 columns needs -12.5%/125%) and ignored the grid's gap and padding. Now the path is converted to pixel centres measured from the real cells (extrapolating the cell pitch for the one-cell margin), drawn in the grid's own pixel space with overflow visible, so it lines up exactly at any board size and routes that leave the board still show. Added a dark halo behind the line plus endpoint dots for contrast on any tile, and lengthened the flash from 240ms to 420ms so it is actually seen.
fix(onet): make the connecting line visible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the fix that makes the Onet connecting line visible and correctly aligned. CI green on develop.