Promote to production: FFmpeg bundling + lint cleanup#42
Open
slaveofcode wants to merge 4 commits into
Open
Conversation
Re-enable externalBin "bin/ffmpeg" so recordings/conversions use a bundled ffmpeg instead of a system install. The compile-time sidecar validation that broke desktop-check before is handled: desktop-check stubs an empty sidecar (cargo check never runs it), release.yml downloads the real per-target binary, and beforeDev/BuildCommand auto-fetch it locally. ffmpeg_path() already prefers the bundled binary next to the exe.
feat(desktop): bundle ffmpeg as a sidecar
Polish/bug-sweep pass over ESLint warnings (109 -> 99; remaining are intentional no-explicit-any and test scaffolding): - Remove 5 unnecessary eslint-disable directives (deps arrays were already correct) and their leftover blank lines. - Prefix intentionally-unused vars with _ (worker.store destructure-omit, file.service stub param); drop a discarded register() return in HotkeyTest; remove a dead downloadService import in CodeScratchpad. - @ts-ignore -> @ts-expect-error in platform detection. - exhaustive-deps: key ToolHost's useMemo on the stable tool ref; document JsonCompare's intentional toggle-only effect. Both reviewed as non-bugs. No behavior change. 429 tests pass; build green.
chore(lint): resolve all source-code lint warnings
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
goodwebtools | 4dc4cdc | Jul 26 2026, 06:26 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the two merged
developchanges to production.Included
externalBin: ["bin/ffmpeg"]re-enabled; compile-time validation handled via a stub indesktop-check.yml, real per-target download inrelease.yml, andbeforeDev/BuildCommandauto-fetch locally. Verified green on macOS/Windows/Linux.no-explicit-anyand test scaffolding). No behavior change.Verification
429 tests pass ·
astro buildgreen ·tscnet-zero new errors.Notes
tauri build); it ships when the nextdesktop-v*tag is cut offmain. No effect on the web deploy.