fix(recording): silent recordings — capture + mux audio correctly - #6
Merged
Conversation
Two bugs made every recording come out silent: 1. TauriCaptureService.startRecording dropped includeAudio/systemAudio before the IPC call, so Rust never started the AudioRecorder. Now forwarded. 2. The mux always used -c:a aac, but WebM (the default output) can't hold AAC — it needs Opus, so the mux failed and left a video-only file. Pick the audio codec by container: mp4 → aac, webm → libopus. Also fixes a build break: the [lints.rust] check-cfg form added earlier is invalid on current rustc (errored with "invalid --check-cfg argument"); switched to `unexpected_cfgs = "allow"`. macOS builds clean (0 warnings); 385 JS tests pass. Needs a mic-enabled recording on hardware to confirm audio lands in the file. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013dqouzFP8vy9jaKhTDFj5H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screen recordings came out silent (video-only stream, confirmed via ffprobe). Two root causes:
TauriCaptureService.startRecordingforwarded onlyformat/fps/displayId/bounds, soincludeAudio/systemAudionever reached Rust and theAudioRecorderwas never started. Now forwarded.-c:a aac, but the default output is WebM, which can't hold AAC (needs Opus). The mux failed → video-only file. Now picks by container:mp4 → aac,webm → libopus.Also fixes a build break
The
[lints.rust]check-cfg = ['cfg(cargo-clippy)']form (added in #5) is invalid on current rustc —cargo builderrors with invalid --check-cfg argument. CI's rustc was lenient so it slipped through. Switched tounexpected_cfgs = "allow".Testing
:0captures your mic is the runtime check).🤖 Generated with Claude Code