Skip to content

Replace deprecated tap functions#6

Merged
jozefizso merged 5 commits into
mainfrom
fix_deprecated_tests_methods
Oct 13, 2024
Merged

Replace deprecated tap functions#6
jozefizso merged 5 commits into
mainfrom
fix_deprecated_tests_methods

Conversation

@jozefizso
Copy link
Copy Markdown
Member

This PR is a back-port for the soldair#380

I replaced all the deprecated functions in tap tests. This keeps the tests output nice and tidy and it allows to upgrade to the latest tap release (v20 for NodeJS 18+, or v21 for NodeJS 20+) in the future.

Test report on master branch:

Suites:   ​33 passed​, ​33 of 33 completed
Asserts:  ​​​6187 passed​, ​of 6187
​Time:​   ​3s

Test report after replacing deprecated functions:

Suites:   ​33 passed​, ​33 of 33 completed
Asserts:  ​​​6187 passed​, ​of 6187
​Time:​   ​2s

@jozefizso jozefizso self-assigned this Oct 13, 2024
@jozefizso jozefizso merged commit 5aaf7d5 into main Oct 13, 2024
@jozefizso jozefizso added this to the v2.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant