fix(raft): fix committed entries never applied due to advance() ordering#124
Merged
Conversation
raft-rs 0.7 delivers committed entries via the LightReady returned by advance(), not in the original Ready. The old code called advance() at the end of the Ready processing loop after take_committed_entries(), which always returned empty. This caused all Raft proposals (writes, linearizable reads) to hang indefinitely. Restructure the Ready processing loop to call advance() before processing committed entries, following the raft-rs 0.7 API contract: 1. Persist entries and hard state 2. Send messages, handle snapshots, process ReadIndex 3. Call advance() to get LightReady 4. Process committed entries from LightReady 5. Call advance_apply() to signal completion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LightReadyreturned byadvance(), not in the originalReady. The old code calledadvance()aftertake_committed_entries(), which always returned empty.Changes
advance()before processing committed entries fromLightReady.Testing
cargo test)cargo clippy -- -D warnings— 0 warningscargo fmt -- --check— OK