fix(raft): fix election and network issues in raft event loop#126
Merged
Conversation
Replace spin-based ticking with Instant-based accurate timing to prevent tick drift. Reorder ready processing to send leader messages before persisting entries, matching raft-rs best practices. Fix heartbeat interval from 100ms to 200ms and set max_committed_size_per_ready to ensure entries are returned from ready(). Add tracing for raft messages, proposals, and leader state transitions to aid debugging. Improve network sender error handling to distinguish between RPC errors and task panics.
49e26a2 to
75d571d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix several issues in the Raft event loop that caused election instability and unreliable message delivery. Replace spin-based ticking with accurate time-based ticking, reorder ready processing to match raft-rs best practices, and add observability for debugging raft issues.
Changes
MAX_SPINloop withInstant-based tick scheduling to prevent tick drift. Reorder ready processing: send leader messages before persisting entries (parallel path per raft-rs docs). Replaceforloop over ready withwhile node.has_ready(). Add tracing for steps, proposals, and leader state updates.heartbeat_tickfrom 1 (100ms) to 2 (200ms) to reduce heartbeat overhead. Setmax_committed_size_per_readyto 1MB (0 means no entries returned).send_messageerror handling to distinguish RPC errors from task panics. Add structured logging for outgoing raft messages.require_leaderchecks.entries()andterm()store operations.How to verify
cargo build --release cargo test cargo clippy -- -D warnings