[IMPROVEMENT] Use slub repository branches for Docker image#341
Merged
beatrycze-volk merged 2 commits intoslub:masterfrom Feb 24, 2025
Merged
[IMPROVEMENT] Use slub repository branches for Docker image#341beatrycze-volk merged 2 commits intoslub:masterfrom
beatrycze-volk merged 2 commits intoslub:masterfrom
Conversation
beatrycze-volk
added
the
🔗 dependency
beatrycze-volk
approved these changes
Feb 24, 2025
Contributor
beatrycze-volk
left a comment
beatrycze-volk
left a comment
There was a problem hiding this comment.
Thanks for upgrade :)
stweil
reviewed
Feb 24, 2025
| with: | ||
| repository: markusweigelt/dfg-viewer | ||
| ref: update-typo12 | ||
| repository: slub/dfg-viewer |
Contributor
There was a problem hiding this comment.
Fixing this line and also the line below was necessary, but why not using the original code which did not have a hard coded reference to "slub"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the TYPO3 12 changes are in the main branches of the DFG-Viewer and SLUB Digital Collection, the extensions of Docker image can also be built against these repositories.