feat(sweeper): Phase 2D — Orphan revival and delayed-retry promotion - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2D: the durability loop.
internal/sweeper.SweepOncedoes two passes:status=runningjobs whoseworker_idhas no live heartbeat (EXISTS heartbeat:<id>returns 0), callsMarkFailedwith "worker died". Status goes back to queued (or dead if max attempts hit).status=queued AND last_error IS NOT NULL AND next_run_at <= now()jobs and pushes their IDs onto the Redis stage queue. Thelast_error IS NOT NULLfilter avoids re-pushing newly-enqueued jobs whose producer hasn't yet pushed them.queue.IsWorkerAlive(workerID)reader (paired with theHeartbeatwriter from 2C).store.ListRunningJobsandstore.ListReadyRetryJobsplus sharedscanJobshelper.cmd/sweeperbinary: 5 s tick, signal-handled graceful shutdown, slog JSON.6 new tests (2 queue + 2 store + 4 sweeper integration). Existing 22 integration tests still green.
Closes the durability loop. Combined with Phase 2C, a worker that crashes mid-job is recovered automatically; failed jobs back off correctly.
Test plan