Route no-arg pigo update to binary self-update (#468) - #472
Merged
Conversation
Add updateIsSelfUpdate classifier: no positional package name (incl. flags-only like --check) routes to binary self-update; a package name stays pkgmgr package-update. Delete the now-dead no-arg package-all- update path (pkgmgr.UpdateAll) per the no-arg=self-update design.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateIsSelfUpdatepure classifier incmd/pigo/main.go: no positional package name (including flags-only invocations likepigo update --check) routes to binary self-update; a package name routes to pkgmgr package-update.len(os.Args)==2check so flags-only invocations also reach self-update.pkgmgr.UpdateAlland the empty-name branch inrunUpdate(empty name list is now a usage error), per the binding "no-arg = self-update, drop package-all-update" design.TestUpdateIsSelfUpdatecovering 7 classification cases.Closes #468
Test plan
go build ./...go vet ./cmd/pigo/ ./internal/cli/pkgcmd/ ./internal/pkgmgr/go test ./cmd/pigo/ ./internal/pkgmgr/(pkgcmd has no test files)