Skip printing user code when verification URI already includes it#1595
Merged
Skip printing user code when verification URI already includes it#1595
Conversation
When VerificationURIComplete is present in the device authorization response, the user code is already embedded in the URI. Printing the code separately is redundant and potentially confusing. This suppresses the code prompt in that case and shows only the complete URI. This is related to #1430, and the behavior is in line with `kubelogin` Change-Type: behavior Release-Note: yes Audience: user Impact: low Breaking: false
smst-jeff
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When VerificationURIComplete is present in the device authorization response, the user code is already embedded in the URI. Printing the code separately is redundant and potentially confusing.
This suppresses the code prompt in that case and shows only the complete URI.
This is related to #1430, and the behavior is in line with
kubeloginAlso see #1430 (comment).
Change-Type: behavior
Release-Note: yes
Audience: user
Impact: low
Breaking: false