Skip to content

Skip printing user code when verification URI already includes it #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hslatman merged 1 commit into from
Mar 17, 2026
+8 −2
Merged

Skip printing user code when verification URI already includes it #1595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions command/oauth/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,10 +891,12 @@ func (o *oauth) DoDeviceAuthorization() (*token, error) {
return nil, errors.Wrap(err, "failure decoding device authz response to JSON")
}

shouldPrintCode := true
switch {
case idr.VerificationURIComplete != "":
// Prefer VerificationURIComplete if present for user convenience
idr.VerificationURI = idr.VerificationURIComplete
shouldPrintCode = false
case idr.VerificationURI != "":
// do nothing
case idr.VerificationURL != "":
Expand All @@ -909,8 +911,12 @@ func (o *oauth) DoDeviceAuthorization() (*token, error) {
idr.Interval = defaultDeviceAuthzInterval
}

fmt.Fprintf(os.Stderr, "Visit %s and enter the code:\n", idr.VerificationURI)
fmt.Fprintln(os.Stderr, idr.UserCode)
if shouldPrintCode {
fmt.Fprintf(os.Stderr, "Visit %s and enter the code:\n", idr.VerificationURI)
fmt.Fprintln(os.Stderr, idr.UserCode)
} else {
fmt.Fprintf(os.Stderr, "Visit %s:\n", idr.VerificationURI)
}

// Poll the Token endpoint until the user completes the flow.
data = url.Values{}
Expand Down
Loading