fix(rawdata): consolidate malformed xref/startxref and page-tree recovery#816
Closed
vitormattos wants to merge 37 commits into
Closed
fix(rawdata): consolidate malformed xref/startxref and page-tree recovery#816vitormattos wants to merge 37 commits into
vitormattos wants to merge 37 commits into
Conversation
vitormattos
changed the title
vitormattos
added a commit
to vitormattos/pdfparser
that referenced
this pull request
Apr 27, 2026
# Conflicts: # src/Smalot/PdfParser/RawData/RawDataParser.php # tests/PHPUnit/Integration/DocumentIssueFocusTest.php # tests/PHPUnit/Integration/RawData/RawDataParserTest.php
vitormattos
added a commit
to vitormattos/pdfparser
that referenced
this pull request
Apr 28, 2026
# Conflicts: # tests/PHPUnit/Integration/RawData/RawDataParserTest.php
vitormattos
force-pushed
the
fix/rawdata-next-xref-trailer-recovery
branch
from
625e9d0 to
a7cca15
Compare
… to recover-invalid branch
vitormattos
added a commit
to vitormattos/pdfparser
that referenced
this pull request
Apr 29, 2026
vitormattos
added a commit
to vitormattos/pdfparser
that referenced
this pull request
Apr 29, 2026
vitormattos
added a commit
to vitormattos/pdfparser
that referenced
this pull request
Apr 29, 2026
# Conflicts: # src/Smalot/PdfParser/RawData/RawDataParser.php # tests/PHPUnit/Integration/RawData/RawDataParserTest.php
This was referenced Apr 29, 2026
Some PDFs include bytes before the %PDF- header while still using absolute xref offsets from the beginning of the file. The parser trimmed data before %PDF-, which shifted offsets and caused xref lookup failures. This manifested as an Invalid object reference error in the veraPDF corpus header case. Changes: - Keep original byte layout in RawDataParser::parseData - Add stricter trailer key matching for /Size /Root /Encrypt /Info /Prev - Add defensive handling in xref stream resolution when startxref is near, but not exactly at, the xref stream object - Add regression fixture and integration test Regression fixture: - samples/bugs/PullRequestInvalidObjectReference.pdf Test: - DocumentIssueFocusTest::testParseFileWithCompressedObjRefInXrefStream Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Some PDFs set startxref to the whitespace immediately before the xref keyword instead of the first letter of xref. The parser required an exact match and incorrectly switched to xref stream decoding, which then failed with Invalid object reference. Changes: - Skip PDF whitespace before checking startxref position - Use adjusted offset when decoding classic xref - Apply same whitespace tolerance for Unix line-ending detection - Tighten trailer key regexes to match /Size /Root /Encrypt /Info /Prev - Add regression fixture and integration test Regression fixture: - samples/bugs/PullRequestXrefWhitespaceStart.pdf Test: - DocumentIssueFocusTest::testParseFileWhenStartxrefPointsToLeadingWhitespace Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Author
|
Replaced by #795 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve RawData and parser resilience for malformed PDF.js-style documents by combining xref/startxref recovery, tolerant object/header parsing, and page-tree/catalog recovery fixtures.
Included Coverage
Updated Areas
src/Smalot/PdfParser/RawData/RawDataParser.phpsrc/Smalot/PdfParser/Parser.phpsrc/Smalot/PdfParser/Pages.phptests/PHPUnit/Integration/RawData/RawDataParserTest.phptests/PHPUnit/Integration/DocumentIssueFocusTest.phpsamples/bugs/rawdata/*Validation
tests/PHPUnit/Integration/RawData/RawDataParserTest.phptests/PHPUnit/Integration/DocumentIssueFocusTest.php