Fix delayed block breaking sync with renderer/server #442#487
Closed
ModMaker101 wants to merge 2 commits intosmartcmd:mainfrom
Closed
Fix delayed block breaking sync with renderer/server #442#487ModMaker101 wants to merge 2 commits intosmartcmd:mainfrom
ModMaker101 wants to merge 2 commits intosmartcmd:mainfrom
Conversation
Collaborator
|
Does not fix it, this issue still occurs with your changes 2026-03-04.16-22-31.mp4 |
Contributor
Author
|
Yeah, that's my bad I miss read the issue I fixed something else 😅 I'll push a commit to fix that though |
Contributor
Author
|
@codeHusky It was working on my machine after my last commit, so if you could test it yourself that would be great. |
Contributor
check my pr it was a very very simple fix, you just needed to delete one line lol, i am not sure why it was made to return early in the first place |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes delayed block breaking by syncing renderer state, reducing redundant destroy progress updates, and modernizing parts of
MultiPlayerGameMode.Changes
Previous Behavior
destroyTileProgresswas spammed every tick.removeTilecaused client desync.Root Cause
Renderer and client destroy states weren't synced properly, and legacy LCE code spammed progress updates and removed tiles inconsistently.
New Behavior
destroyingTileAt.setTileAndDataused for consistent updates.Fix Implementation
lastSentDestroyStatecaching.destroyingTileAtbefore client destruction.shared_ptr<T>->std::make_shared<T>.Related Issues