fixed delay issue when breaking a block#537
Merged
void2012 merged 1 commit intosmartcmd:mainfrom Mar 5, 2026
Merged
Conversation
Collaborator
|
Yes, this one is obviously better |
|
Is that entire block necessary to have if it's going to continue anyway? If it's Windows and you are the host, it'll call the same function ( |
Contributor
Author
You might be right but it's working as it is with no bugs so doesn't really matter, if later on it does cause issues I'll remove the extra line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixed delay issue when breaking a block
Previous Behavior
Previously, MultiPlayerGameMode::destroyBlock returned early on the host after spawning block breaking particles, skipping the actual block removal. This caused a delay where the block appeared to remain solid for a moment.
Video (credits to codeHusky for the vid):
558345396-6cfdaa20-adf4-4be0-8c9a-411c138aa744.mp4
Root Cause
MultiPlayerGameMode::destroyBlock returned early
New Behavior
lets MultiPlayerGameMode::destroyBlock actaully continue
Minecraft.2026-03-05.05-41-44.mp4