Skip to content

fixed delay issue when breaking a block#537

Merged
void2012 merged 1 commit intosmartcmd:mainfrom
MarvelcoOGFN:main
Mar 5, 2026
Merged

fixed delay issue when breaking a block#537
void2012 merged 1 commit intosmartcmd:mainfrom
MarvelcoOGFN:main

Conversation

@MarvelcoOGFN
Copy link
Contributor

Description

fixed delay issue when breaking a block

Previous Behavior

Previously, MultiPlayerGameMode::destroyBlock returned early on the host after spawning block breaking particles, skipping the actual block removal. This caused a delay where the block appeared to remain solid for a moment.

Video (credits to codeHusky for the vid):

558345396-6cfdaa20-adf4-4be0-8c9a-411c138aa744.mp4

Root Cause

MultiPlayerGameMode::destroyBlock returned early

New Behavior

lets MultiPlayerGameMode::destroyBlock actaully continue

Minecraft.2026-03-05.05-41-44.mp4

@void2012
Copy link
Collaborator

void2012 commented Mar 5, 2026

Yes, this one is obviously better

@void2012 void2012 merged commit c77bb4d into smartcmd:main Mar 5, 2026
@AgentAgrimar
Copy link

Is that entire block necessary to have if it's going to continue anyway?

If it's Windows and you are the host, it'll call the same function (level->levelEvent) twice on top of that, unless that behavior is intended.

@MarvelcoOGFN
Copy link
Contributor Author

Is that entire block necessary to have if it's going to continue anyway?

If it's Windows and you are the host, it'll call the same function (level->levelEvent) twice on top of that, unless that behavior is intended.

You might be right but it's working as it is with no bugs so doesn't really matter, if later on it does cause issues I'll remove the extra line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants