Skip to content

[HTTP Trigger] Respond to Gateway before emitting an event #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bolekk merged 1 commit into from
Sep 4, 2026
Merged

[HTTP Trigger] Respond to Gateway before emitting an event #745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions http_trigger/trigger/connector_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,18 +359,17 @@ func (h *connectorHandler) processTrigger(ctx context.Context, gatewayID string,
}
l.Debug("Workflow triggered successfully")

// Emit TriggerExecutionStarted event
if emitErr := events.EmitTriggerExecutionStarted(ctx, labeler); emitErr != nil {
l.Errorw("failed to emit trigger execution started event", "error", emitErr)
}

l.Debug("Sending response to gateway")
h.sendResponse(ctx, gatewayID, resp)

err = h.cacheRequestResponse(ctx, req, workflowMetadata.WorkflowID, workflowExecutionID, resp, l)
if err != nil {
l.Errorw("Failed to cache request response", "error", err)
}
l.Debug("Sent response to gateway")

if emitErr := events.EmitTriggerExecutionStarted(ctx, labeler); emitErr != nil {
l.Errorw("failed to emit trigger execution started event", "error", emitErr)
}
l.Debug("Trigger event processed")
}

type WorkflowMetadata struct {
Expand Down
Loading