feat(cresettings): add GatewayConfidentialRelayUserRate ingress limit#2268
Open
nadahalli wants to merge 1 commit into
Open
feat(cresettings): add GatewayConfidentialRelayUserRate ingress limit#2268nadahalli wants to merge 1 commit into
nadahalli wants to merge 1 commit into
Conversation
Adds a GatewayConfidentialRelayUserRate setting (default 100rps, burst 10) so the confidential relay gateway handler in chainlink core can throttle inbound user requests before fan-out to DON nodes. The existing relay limiters only bound node responses, leaving the ingress path unthrottled. Consumed by chainlink core for CL112-03 / PRIV-436 (Sigma Prime audit).
Contributor
✅ API Diff Results -
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new CRE setting to rate-limit confidential relay ingress (user → gateway) requests to prevent unauthenticated amplification before fan-out to DON nodes.
Changes:
- Introduces
GatewayConfidentialRelayUserRateto the CRE settings schema with a default of100rps:10. - Updates golden defaults (
defaults.json,defaults.toml) and unmarshalling test coverage for the new setting. - Extends the CRE settings limits diagram to include the new rate limiter (but currently places it under a node→gateway subgraph; see PR comment).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/settings/cresettings/settings.go | Adds the new GatewayConfidentialRelayUserRate setting and default. |
| pkg/settings/cresettings/settings_test.go | Extends TestSchema_Unmarshal to include/assert the new rate setting. |
| pkg/settings/cresettings/README.md | Adds the setting to the Mermaid limits diagram (placement likely needs adjustment). |
| pkg/settings/cresettings/defaults.toml | Adds default value for GatewayConfidentialRelayUserRate. |
| pkg/settings/cresettings/defaults.json | Adds default value for GatewayConfidentialRelayUserRate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
61
to
68
| subgraph HandleNodeMessage[gatewayHandler.HandleNodeMessage] | ||
| %% DON nodes → gateway (separate from the inbound trigger flow) | ||
| GatewayHTTPGlobalRate[\GatewayHTTPGlobalRate/]:::rate | ||
| GatewayHTTPPerNodeRate[\GatewayHTTPPerNodeRate/]:::rate | ||
| GatewayConfidentialRelayGlobalRate[\GatewayConfidentialRelayGlobalRate/]:::rate | ||
| GatewayConfidentialRelayPerNodeRate[\GatewayConfidentialRelayPerNodeRate/]:::rate | ||
| GatewayConfidentialRelayUserRate[\GatewayConfidentialRelayUserRate/]:::rate | ||
| GatewayHTTPActionMtlsRequestRate[\GatewayHTTPActionMtlsRequestRate/]:::rate |
ilija42
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
GatewayConfidentialRelayUserRatesetting (default 100rps, burst 10) so theconfidential relay gateway handler in chainlink core can throttle inbound user
requests before fan-out to DON nodes. The existing relay limiters
(
GatewayConfidentialRelayGlobalRate,PerNodeRate) only bound node responses,leaving the ingress path unthrottled.
Consumed by the chainlink core change for CL112-03 / PRIV-436 (Sigma Prime audit
finding: unauthenticated relay ingress amplifies one request into per-node
attestation work). The core handler reads it via
MakeRateLimiter, same as the twoexisting relay limiters.