Conversation
|
Go solidity wrappers are out-of-date, regenerate them via the |
aiagentdev-1990
changed the title
aiagentdev-1990
requested review from
a team,
archseer,
bolekk and
patrick-dowell
as code owners
contracts/src/v0.8/keystone/test/CapabilityRegistry_AddDONTest.t.sol
Outdated
Show resolved
Hide resolved
|
@cds95 took this over. I approve this PR. |
| /// @dev This is stored as a map so that we can easily update to a set of | ||
| /// new capabilities by incrementing the configCount and creating a | ||
| /// new set of supported capability IDs | ||
| mapping(uint32 configCount => EnumerableSet.Bytes32Set capabilityId) supportedCapabilityIds; |
There was a problem hiding this comment.
Is there a use case for seeing the capabilities supported by a node at a previous config count?
There was a problem hiding this comment.
Asking because we only seem to return the latest - is this just less gassy?
There was a problem hiding this comment.
Yes we basically need a quick way to track the latest supported capability IDs after updateNodes is called. The alternative would have been to loop through all the capability IDs and remove them from the set one by one and adding the new capability IDs. Adding the configCount allows us to just read the latest supported IDs.
| function getDONCapabilityConfig(uint32 donId, bytes32 capabilityId) external view returns (bytes memory) { | ||
| return s_dons[donId].capabilityConfigs[capabilityId]; |
There was a problem hiding this comment.
Should this also return the configuration contract's getCapabilityConfiguration(donId) as well?
|
3 participants
No description provided.