Add Transmit debug logging back in#13128
Merged
Conversation
samsondav
force-pushed
the
add_transmit_debug_logging
branch
from
0abeca2 to
62a9e66
Compare
samsondav
force-pushed
the
add_transmit_debug_logging
branch
from
62a9e66 to
e60085a
Compare
samsondav
force-pushed
the
add_transmit_debug_logging
branch
2 times, most recently
from
3ff0136 to
267c8bd
Compare
samsondav
force-pushed
the
add_transmit_debug_logging
branch
from
267c8bd to
5cb8f00
Compare
|
jmank88
reviewed
May 10, 2024
| if err != nil { | ||
| mt.lggr.Warnw("Failed to get observation timestamp from report", "err", err) | ||
| } | ||
| mt.lggr.Debugw("Transmit enqueue", "req.Payload", hexutil.Encode(req.Payload), "report", report, "repts", reportCtx.ReportTimestamp, "signatures", signatures, "observationsTimestamp", ts) |
Contributor
There was a problem hiding this comment.
Will this log line be mangled if we didn't get a real ts back? Could exclude that key/val for that case
Contributor
Author
There was a problem hiding this comment.
Only time that should happen is with block number report, and will just log zero which is ok
jmank88
approved these changes
May 10, 2024
brunotm
approved these changes
May 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.