Validate keystone workflows + Enforce full semver on capabilities#13328
Validate keystone workflows + Enforce full semver on capabilities#13328cedric-cordenier merged 9 commits intodevelopfrom
Conversation
|
HenryNguyen5
changed the title
| "missing name", | ||
| func() string { | ||
| id := "15c631d295ef5e32deb99a10ee6804bc4af1385568f9b3363f6552ac6dbb2cef" | ||
| owner := "00000000000000000000000000000000000000aa" |
There was a problem hiding this comment.
The owner needs to be within the workflow spec (not the "job spec for the workflow"), as the nodes will need to get the owner from the workflow after validating signatures, right?
There was a problem hiding this comment.
I'm not too sure, I kept the structure of the test cases the same as trunk. I think we should address this in a separate topic as I want to get validation for workflow specs (not job specs) merged in first.
There was a problem hiding this comment.
@DeividasK It's not part of the workflow spec (at least it wasn't last time I checked). We do pass it from the workflow spec to the RequestMetadata thus making it available to capabilities though
4 participants
This PR contains the following changes:
CapabilityInfostruct now embeds the version as part of the ID itself, rather than having it as a separate field.Prior arts:
Related PR: smartcontractkit/chainlink-common#536