Conversation
|
| //go:generate mockery --quiet --name Client --output ./mocks/ --case=underscore | ||
|
|
||
| // Client is the interface used to interact with an ethereum node. | ||
| type Client interface { |
There was a problem hiding this comment.
Shouldn't we keep it in client.go file?
There was a problem hiding this comment.
I'd rather keep one file for interface and implementation instead of splitting them. Interfaces should live either where they are needed or if they are of general purpose inside their implementation.
| return context.WithTimeout(context.Background(), queryTimeout) | ||
| } | ||
|
|
||
| type chainClient struct { |
There was a problem hiding this comment.
Shouldn't we rename it to client?
There was a problem hiding this comment.
Thought of the same thing and I actually made the change locally, but then chainClient as a name kinda grew on me and decided not to make the switch. I'm happy with both to be honest.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
4 participants
Old evm client wasn't used and MultiNode was used in its place. The code has been deprecated for a long time. We are removing all the unnecessary files and deprecating the old evm client.