Add additional capability and DON metadata#13425
Merged
cedric-cordenier merged 11 commits intodevelopfrom Jun 6, 2024
Merged
Conversation
DeividasK
requested review from
a team,
archseer,
bolekk and
patrick-dowell
as code owners
archseer
previously approved these changes
Jun 5, 2024
…nal-capability-and-don-metadata
cedric-cordenier
previously approved these changes
Jun 5, 2024
| /// @notice DONParams is a struct that holds the parameters for a DON. | ||
| /// @dev This is needed to avoid "stack too deep" errors in _setDONConfig. | ||
| struct DONParams { | ||
| uint32 id; |
Contributor
There was a problem hiding this comment.
Add natspec comments for the params
Contributor
Author
There was a problem hiding this comment.
Will do in a follow-up to avoid losing approvals on this PR
aiagentdev-1990
previously approved these changes
Jun 5, 2024
archseer
previously approved these changes
Jun 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
…nal-capability-and-don-metadata # Conflicts: # core/gethwrappers/keystone/generation/generated-wrapper-dependency-versions-do-not-edit.txt
DeividasK
dismissed stale reviews from aiagentdev-1990 and cedric-cordenier
via
d8b1074
archseer
approved these changes
Jun 6, 2024
cedric-cordenier
approved these changes
Jun 6, 2024
cedric-cordenier
deleted the
KS-284-add-additional-capability-and-don-metadata
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.