[Keystone] Add remote target to syncer#13456
Merged
Conversation
0ca8535 to
fa23c4e
Compare
fa23c4e to
567a0ec
Compare
ettec
requested changes
Jun 7, 2024
4ecc7e4 to
b887ec7
Compare
cedric-cordenier
previously approved these changes
Jun 7, 2024
ettec
previously approved these changes
Jun 7, 2024
1. Refactor remote target client/server to implement services.Service 2. Use service-wide context when launching NewClientRequest 3. Handle early termination in Engine 4. Logging improvements
088b681 to
98a482f
Compare
cedric-cordenier
previously approved these changes
Jun 7, 2024
ettec
previously approved these changes
Jun 7, 2024
ettec
approved these changes
Jun 7, 2024
cedric-cordenier
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on smartcontractkit/chainlink-common#565