Skip to content

fixed bug related to differences in cursor structure#14579

Merged
EasterTheBunny merged 3 commits into
developfrom
ah/query-key-cursor-bug
Sep 27, 2024
Merged

fixed bug related to differences in cursor structure#14579
EasterTheBunny merged 3 commits into
developfrom
ah/query-key-cursor-bug

Conversation

@EasterTheBunny
Copy link
Copy Markdown
Contributor

The pattern for creating a cursor and splitting data in a cursor were not consistent and resulting in inconsistent results when using cursors in QueryKey.

Requires

Resolves

No corresponding tickets, but fixes a bug related to cursors in QueryKey.

@EasterTheBunny EasterTheBunny requested review from a team as code owners September 26, 2024 18:59
@EasterTheBunny EasterTheBunny requested review from jmank88 and removed request for a team September 26, 2024 18:59
Comment thread core/chains/evm/logpoller/parser.go Outdated
EasterTheBunny and others added 2 commits September 26, 2024 16:29
Co-authored-by: Jordan Krage <jmank88@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@cl-sonarqube-production
Copy link
Copy Markdown

@ilija42 ilija42 added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@EasterTheBunny EasterTheBunny added this pull request to the merge queue Sep 27, 2024
Merged via the queue into develop with commit f9fe452 Sep 27, 2024
@EasterTheBunny EasterTheBunny deleted the ah/query-key-cursor-bug branch September 27, 2024 14:17
AnieeG pushed a commit that referenced this pull request Sep 30, 2024
* fixed bug related to differences in cursor structure

* Update core/chains/evm/logpoller/parser.go

Co-authored-by: Jordan Krage <jmank88@gmail.com>

* reference new func

---------

Co-authored-by: Jordan Krage <jmank88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants