Conversation
karen-stepanyan
changed the title
karen-stepanyan
force-pushed
the
feed-id-validation
branch
from
9a9a51c to
f8cd9ea
Compare
alecgard
reviewed
Mar 25, 2025
alecgard
approved these changes
Mar 25, 2025
|
jkongie
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate and convert feed ids passed to changesets
Also
refactored
NewFeedWithProxyChangesetto accept multiple data ids. This will make it easier to deploy several feeds on the same networkrefactored
AcceptOwnershipChangesetto accept multiple contract addresses. This will make easier to transfer ownership of many contract to MCMS at onceMoved shared/utils.go to changeset/utils.go