Skip to content

Update EVM to use new Generalized WT #17216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MStreet3 merged 49 commits into from
Jun 18, 2025
Merged

Update EVM to use new Generalized WT #17216

MStreet3 merged 49 commits into from
Jun 18, 2025

Conversation

@silaslenihan
Copy link
Contributor

@silaslenihan silaslenihan commented Apr 9, 2025 •
edited
Loading

This PR includes the previous EVM WT Extraction that was reverted from develop as well as new changes to inject chain-specific code into the Generalized WT, along with expanded tests.

Requires

Supports

@silaslenihan silaslenihan requested review from a team as code owners April 9, 2025 23:48
@github-actions github-actions bot added the runs-on opt-in to self-hosted runners for certain jobs label Apr 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@silaslenihan silaslenihan force-pushed the fix/inject-evm-df-decoder branch 5 times, most recently from 9e3e596 to 33dfa69 Compare April 10, 2025 01:57
krebernisak
krebernisak reviewed Apr 10, 2025
View reviewed changes
@silaslenihan silaslenihan force-pushed the fix/inject-evm-df-decoder branch from bd403eb to b79c831 Compare April 10, 2025 14:35
krebernisak
krebernisak previously approved these changes Apr 10, 2025
View reviewed changes
@silaslenihan silaslenihan force-pushed the fix/inject-evm-df-decoder branch 2 times, most recently from cce3d86 to e7cb471 Compare April 10, 2025 19:18
krebernisak
krebernisak previously approved these changes Apr 11, 2025
View reviewed changes
@silaslenihan silaslenihan force-pushed the fix/inject-evm-df-decoder branch 2 times, most recently from 0d5431c to 6c8cc15 Compare April 30, 2025 19:41
@silaslenihan silaslenihan requested review from a team as code owners May 7, 2025 15:41
@silaslenihan silaslenihan requested review from a team as code owners May 12, 2025 20:39
dhaidashenko
dhaidashenko previously approved these changes Jun 18, 2025
View reviewed changes
jmank88
jmank88 reviewed Jun 18, 2025
View reviewed changes
@silaslenihan silaslenihan force-pushed the fix/inject-evm-df-decoder branch from 3c6447a to e06a6f9 Compare June 18, 2025 17:52
jmank88
jmank88 previously approved these changes Jun 18, 2025
View reviewed changes
ilija42
ilija42 previously approved these changes Jun 18, 2025
View reviewed changes
@MStreet3 MStreet3 added the run-e2e-tests Use on your PR to run E2E tests before the merge queue label Jun 18, 2025
@silaslenihan silaslenihan dismissed stale reviews from ilija42 and jmank88 via ef14b5d June 18, 2025 21:12
MStreet3
MStreet3 reviewed Jun 18, 2025
View reviewed changes
core/services/relay/evm/target_strategy.go

type Config struct {
// Address of the contract that will get the forwarded report
Address string
Copy link
Contributor

@MStreet3 MStreet3 Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to leave this as config and not move to input? At least two user requests have a use case to dynamically set the address.

Copy link
Contributor Author

@silaslenihan silaslenihan Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not aware of a reason why this couldn't be an input, but I think this discussion is out of scope for this PR and should be a followup

@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Jun 18, 2025

Quality Gate passed Quality Gate passed

Issues
6 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@silaslenihan silaslenihan requested review from MStreet3, dhaidashenko, ilija42 and jmank88 and removed request for MStreet3 June 18, 2025 21:39
@MStreet3 MStreet3 added this pull request to the merge queue Jun 18, 2025
Merged via the queue into develop with commit c62ba38 Jun 18, 2025
246 of 249 checks passed
@MStreet3 MStreet3 deleted the fix/inject-evm-df-decoder branch June 18, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 approved these changes

@MStreet3 MStreet3 MStreet3 approved these changes

@krehermann krehermann krehermann approved these changes

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny EasterTheBunny is a code owner automatically assigned from smartcontractkit/foundations

@winder winder Awaiting requested review from winder winder was automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 was automatically assigned from smartcontractkit/ccip-offchain

@matYang matYang Awaiting requested review from matYang matYang was automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd was automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv was automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang was automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami was automatically assigned from smartcontractkit/ccip-offchain

@krebernisak krebernisak Awaiting requested review from krebernisak

@ilija42 ilija42 Awaiting requested review from ilija42

@dhaidashenko dhaidashenko Awaiting requested review from dhaidashenko

Assignees

No one assigned

Labels

build-publish Build and Publish image to SDLC run-e2e-tests Use on your PR to run E2E tests before the merge queue runs-on opt-in to self-hosted runners for certain jobs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@silaslenihan @krebernisak @jmank88 @MStreet3 @krehermann @dhaidashenko @ilija42