Convert evm/test/Oracle_test.js to ethers#1815
Merged
HenryNguyen5 merged 7 commits intodevelopfrom Nov 1, 2019
Merged
Conversation
HenryNguyen5
commented
Oct 24, 2019
| await maliciousRequester.request( | ||
| specId, | ||
| link.address, | ||
| ethers.utils.toUtf8Bytes('transfer(address,uint256)'), |
Contributor
Author
There was a problem hiding this comment.
@se3000 I'm encoding the function signatures as utf8 in byte form, when previously we were calling h.toHex which would call the following code
Buffer.from(arg, 'ascii').toString('hex'), so it would be the same resulting output.
Is this how it should be? Or should we consider passing in the sighash of the function in another PR since this would change test behaviour?
j16r
previously approved these changes
Oct 25, 2019
HenryNguyen5
force-pushed
the
chore/type_evm_tests_8
branch
from
26b39df to
171c971
Compare
rupurt
previously approved these changes
Oct 31, 2019
HenryNguyen5
force-pushed
the
chore/type_evm_tests_8
branch
from
171c971 to
1ce88a4
Compare
rupurt
approved these changes
Oct 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.