Trim extra Runnable() check from run executor#1917
Merged
Conversation
dimroc
reviewed
Nov 11, 2019
| taskRun.ApplyOutput(result) | ||
| run.ApplyOutput(result) | ||
|
|
||
| if !result.Status().Runnable() { |
Contributor
There was a problem hiding this comment.
I'm not sure this is ok. I believe that the calls above can change the status again such that Runnable() is false.
ie: the following lines could change Status
result := je.executeTask(&run, taskRun)
taskRun.ApplyOutput(result)
run.ApplyOutput(result)My memory of the code could very well be outdated, so I would double check.
Contributor
There was a problem hiding this comment.
It is only a logger.Debugw statement so not the end of the world.
Contributor
Author
There was a problem hiding this comment.
The following lines could change the status, but if you follow the linear expanded flow, the code used to look like this:
result := je.executeTask(&run, taskRun)
taskRun.ApplyOutput(result)
run.ApplyOutput(result)
if finished {
logger.Debug
}
if finished {
continue
}
now it is:
result := je.executeTask(&run, taskRun)
taskRun.ApplyOutput(result)
run.ApplyOutput(result)
if finished {
logger.Debug
continue
}
dimroc
approved these changes
Nov 11, 2019
Contributor
dimroc
left a comment
dimroc
left a comment
There was a problem hiding this comment.
for loop ensures debug statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.