Skip to content

Render JSON-API errors on 422 unprocessable entity#1920

Merged
rupurt merged 1 commit intodevelopfrom
chore/render-json-api-errors-422
Nov 12, 2019
Merged

Render JSON-API errors on 422 unprocessable entity#1920
rupurt merged 1 commit intodevelopfrom
chore/render-json-api-errors-422

Conversation

@rupurt
Copy link
Copy Markdown
Contributor

@rupurt rupurt commented Nov 11, 2019

Before:

Screen Shot 2019-11-11 at 3 38 02 PM

After:

Screen Shot 2019-11-11 at 3 36 36 PM

@rupurt rupurt requested a review from RyanRHall November 12, 2019 16:00
@j16r
Copy link
Copy Markdown
Contributor

j16r commented Nov 12, 2019

Is parse: empty url coming from the server?

@rupurt rupurt requested a review from j16r November 12, 2019 18:28
Copy link
Copy Markdown
Contributor

@RyanRHall RyanRHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rupurt rupurt merged commit 2719d92 into develop Nov 12, 2019
@rupurt rupurt deleted the chore/render-json-api-errors-422 branch November 12, 2019 20:19
@rupurt
Copy link
Copy Markdown
Contributor Author

rupurt commented Nov 12, 2019

Is parse: empty url coming from the server?

@j16r yes

@j16r
Copy link
Copy Markdown
Contributor

j16r commented Nov 12, 2019

Thanks @rupurt, I think we may want to improve those: https://www.pivotaltracker.com/story/show/169717185

@rupurt
Copy link
Copy Markdown
Contributor Author

rupurt commented Nov 12, 2019

@j16r yeah agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants