Remove statisticsLogger from runQueue, prometheus does this now#2059
Merged
Conversation
coventry
previously approved these changes
Dec 20, 2019
j16r
force-pushed
the
chore/remove_run_queue_statistics_goroutine
branch
3 times, most recently
from
1835ced to
cf238e9
Compare
j16r
force-pushed
the
chore/remove_run_queue_statistics_goroutine
branch
from
cf238e9 to
67d3548
Compare
dimroc
approved these changes
Dec 20, 2019
pkcll
added a commit
that referenced
this pull request
May 18, 2026
pull Bot
pushed a commit
to lokera666/chainlink
that referenced
this pull request
May 21, 2026
* chip ingress: consolidate initial batch emitter setup Squash the pre-default-enable setup commits into one logical change while preserving later commits from d4d8275 onward as separate commits. * Enable ChipIngressBatchEmitterEnabled by default Change the default value of ChipIngressBatchEmitterEnabled from false to true so batch emitting is the default behavior for chip-ingress events. * Update go.mod/go.sum for chainlink-common and chipingress Bump chainlink-common to 843865edbfdc and chipingress to v0.0.11 pre-release, hashicorp/go-plugin to v1.8.0, and add go.uber.org/goleak indirect dependency. * Move beholder lifecycle to Shell and set ChipIngressLogger Move beholder Client.Start/Close from application managed services to Shell.beforeNode/afterNode so the client lifecycle is owned by the CLI layer. Set ChipIngressLogger in the beholder Config (required when ChipIngressBatchEmitterEnabled is true) and reorder initialisation so log streaming is wired before Start(), ensuring the batch emitter service sees the fully-configured logger from the start. * Add ChipIngress batching smoke test Add ExecuteChipIngressBatchingTest and its suite entry Test_CRE_V2_ChipIngress_Batching that starts a CHiP test sink, deploys a cron workflow, and asserts user-log delivery via the batch emitter path. * Add CHiP sink assertion to cron invalid-schedule regression test Extend CronBeholderFailsWithInvalidScheduleTest to also start a CHiP test sink and assert the engine-init-error BaseMessage arrives via the batch path, in addition to the existing Beholder/Kafka assertion. * Update chainlink-common/chipingress to infoplat-3436 branch heads Bump chainlink-common and chipingress module references to the infoplat-3436-chipingress-publishBatch branch revisions requested after merging latest develop. * Refactor beholder lifecycle to Shell field and fix test coverage Extract newBeholderClient and setupLogStreaming from beforeNode/initGlobals to use Shell.BeholderClient instead of the global beholder singleton. Update tests: split telemetry enabled/disabled cases, add nil-client AfterNode test, and add SetOtelCore-nil error path coverage. * chore: shorten newBeholderClient comment * chore: bump chainlink-common chipingress batching deps * gomodtidy * fix: resolve lint errors in beholder lifecycle code * refactor: assign no-op beholder client when telemetry disabled Store beholder.NewNoopClient() in the else branch so downstream code never needs to nil-check BeholderClient after BeforeNode completes. Remove redundant nil guards in Start and setupLogStreaming paths. * fix: update tests for no-op beholder client and ChipIngressBatchEmitterEnabled - shell_local_test: expect non-nil BeholderClient when telemetry disabled - config_test: set ChipIngressBatchEmitterEnabled=true to match config-full.toml fixture * chore: bump chipingress to main, chainlink-common to infoplat-3436-chipingress-batching-part-2 - chipingress v0.0.11-0.20260515172105-f60f14be40ad - chainlink-common v0.11.2-0.20260515174137-7ec6e1a68760 - ran make gomodtidy across all modules * fix: remove duplicate batch forwarding in chip-testsink PublishBatch already forwards via Publish; the batch-level forwarding caused duplicate upstream calls. * fix: set telemetry endpoint in beholder lifecycle tests Tests with Telemetry.Enabled=true need a valid Endpoint and InsecureConnection to avoid gRPC dial failures in CI. * chore: bump chainlink-common for chip ingress batching * Bump chainlink-common to infoplat-3436-chipingress-batching-part-2, chipingress to main * gomodtidy * Bump chainlink-common to infoplat-3436-chipingress-batching-part-2 (20260518192623) * Bump chainlink-common to infoplat-3436-chipingress-batching-part-2 (20260518200833) * Bump chainlink-common to infoplat-3436-chipingress-batching-part-2 (20260518200833) * Bump chainlink-common from main (20260518203858, PR smartcontractkit#2059) * Remove nil guard on BeholderClient.Close since it always defaults to noop BeholderClient is always assigned in beforeNode (either a real client or beholder.NewNoopClient()), so the nil check in afterNode is unnecessary. * Fix shell_local_test: ensure noop BeholderClient before AfterNode cleanup * gomodtidy * Run go mod tidy * Remove empty chip ingress batching test stubs * Bump chainlink-common and chipingress to main * Restore ChipIngressBatchEmitterEnabled config lost during merge --------- Co-authored-by: Pavel <177363085+pkcll@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove this poor person's prometheus I was using briefly.