feat(heartbeat): add EVM RPC node domain labels to beholder metrics #20645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add WSURL_{chainID} and HTTPURL_{chainID} labels to heartbeat metrics
to enable RPC visibility via Beholder. This allows identification of
third-party RPC usage across EVM chains.
For privacy and security, only the domain (host) is extracted from
node URLs, stripping API keys and other sensitive path information.
Changes:
- Add EVMNodeURLs field to HeartbeatConfig
- Extract domains from EVM node WSURL and HTTPURL in NewHeartbeatConfig
- Add ExtractDomainFromURLString helper function
- Add labels to heartbeat emitter for each chain's RPC endpoints
- Add comprehensive tests for domain extraction and config handling
RANE-4333
Contributor
|
I see you updated files related to
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds EVM RPC node domain labels to heartbeat metrics for improved observability in Beholder, while protecting sensitive information like API keys by extracting only the domain portion of node URLs.
Key changes:
- Added EVMNodeURLs field to HeartbeatConfig to store extracted domains mapped by chain ID
- Implemented ExtractDomainFromURLString helper to safely extract domains from URLs
- Updated NewHeartbeatConfig to populate EVM node domains for all configured chains
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/services/chainlink/heartbeat.go | Adds EVMNodeURLs config field, implements domain extraction logic in NewHeartbeatConfig, and adds extracted domains as labels to heartbeat metrics |
| core/services/chainlink/heartbeat_test.go | Adds comprehensive tests for domain extraction edge cases and HeartbeatConfig initialization with various EVM node URL configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…RANE-4333-rpc-node-endpoint
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WSURL_{chainID} and HTTPURL_{chainID} labels to heartbeat metrics to enable RPC visibility via Beholder.
For privacy and security, only the domain (host) is extracted from node URLs, stripping API keys and other sensitive path information.
Changes: