Skip to content

Conversation

@anirudhwarrier
Copy link
Contributor

@anirudhwarrier anirudhwarrier commented Jan 9, 2026

DEVSVCS-3469

This pull request adds support for enabling all chains during workflow execution using standalone engine. It introduces a new command-line flag and propagates the configuration through the workflow runner and engine setup, allowing the workflow to permit all chains when the flag is set. This is now required since #20548

Feature: Enable all chains for workflow execution

  • Added a new --allChains flag to the cre command-line tool, allowing users to enable all chains during workflow execution for testing purposes. [1] [2]
  • Passed the new flag's value via the WorkflowSettingsCfgFn function through the runner and engine setup to configure per-chain settings accordingly. [1] [2] [3] [4]
  • Allow Standalone Engine to be instantiated with AllowedChains config as desired. Allows the simulator in cre-cli to continue to work with chainlink dep update.

Internal: Dependency and configuration propagation

  • Updated imports to include cresettings and related settings packages in relevant files to support the new configuration logic. [1] [2] [3]
  • Modified the engine initialization to accept and utilize the WorkflowSettingsCfgFn for setting up chain permissions, ensuring that the --allChains flag is respected during workflow execution.

Requires

Supports

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cl-sonarqube-production
Copy link

@anirudhwarrier anirudhwarrier marked this pull request as ready for review January 9, 2026 10:54
@anirudhwarrier anirudhwarrier requested a review from a team as a code owner January 9, 2026 10:54
Copilot AI review requested due to automatic review settings January 9, 2026 10:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for configuring workflow execution to permit all chains when running the standalone CRE engine. It introduces a new --allChains command-line flag that allows users to bypass chain restrictions during testing.

Key changes:

  • Added --allChains CLI flag to enable all chains during workflow execution
  • Propagated workflow settings configuration through the runner and engine initialization chain
  • Updated NewStandaloneEngine to accept and apply workflow settings configuration

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
core/services/workflows/cmd/cre/main.go Added --allChains flag and configuration function to pass chain settings to the runner
core/services/workflows/cmd/cre/utils/runner.go Added WorkflowSettingsCfgFn field to RunnerConfig and propagated it to engine creation
core/services/workflows/cmd/cre/utils/standalone_engine.go Updated NewStandaloneEngine signature to accept and use workflow settings configuration function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@anirudhwarrier anirudhwarrier added this pull request to the merge queue Jan 9, 2026
Merged via the queue into develop with commit ceed3e4 Jan 9, 2026
209 checks passed
@anirudhwarrier anirudhwarrier deleted the DEVSVCS-3469/standalone-engine-limits-update branch January 9, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants