[chore] Address nits from previous PRs

[cedric-cordenier]

Address nits from:

• [PRIV-322] Add better observability to the Vault plugin #20846
• [PRIV-315] Vault plugin improvements #20770

[Copilot]

Pull request overview

This PR addresses minor nits from previous pull requests, focusing on metric tracking improvements and a bug fix.

Changes:

• Added success tracking to report metrics in the beholder wrapper
• Fixed incorrect chain type value for Offchain from 8 to 9
• Added queue overflow metrics and logging for the vault plugin

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
core/services/ocr3_1/beholderwrapper/types.go	Added success parameter to trackReports for tracking successful vs failed operations
core/services/ocr3_1/beholderwrapper/plugin.go	Updated trackReports calls to include error state
core/services/ocr2/plugins/vault/plugin.go	Added metrics tracking, queue overflow logging, and documentation
core/services/ocr2/plugins/vault/metrics.go	Created new metrics infrastructure for tracking queue overflow events
core/services/keystore/chaintype/chaintype.go	Corrected Offchain chain type value from 8 to 9

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

👋 cedric-cordenier, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

[github-actions]

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
5 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube