-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Apply engine limits on confidential-http #21000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
I see you updated files related to
|
… into confidential-http-engine-limits
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates workflow engine configuration to introduce a dedicated limiter for confidential HTTP capability calls, alongside bumping github.com/smartcontractkit/chainlink-common across modules to a newer pseudo-version.
Changes:
- Bump
github.com/smartcontractkit/chainlink-commontov0.9.6-0.20260203025122-0da324f1967cacross multiple Go modules in the repo. - Add
ConfidentialHTTPCallsas a newEngineLimitersbound limiter sourced fromcfg.ConfidentialHTTP.CallLimit, and include it in limiter shutdown (Close()). - Register a call-limiter mapping for
{"confidential-http", "SendRequests"}in the workflow capability executor.
Reviewed changes
Copilot reviewed 9 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| system-tests/tests/go.mod | Bumps chainlink-common dependency version for system tests module. |
| system-tests/tests/go.sum | Updates sums for the bumped chainlink-common version. |
| system-tests/lib/go.mod | Bumps chainlink-common dependency version for system test lib module. |
| system-tests/lib/go.sum | Updates sums for the bumped chainlink-common version. |
| integration-tests/load/go.mod | Bumps chainlink-common dependency version for load tests module. |
| integration-tests/load/go.sum | Updates sums for the bumped chainlink-common version. |
| integration-tests/go.mod | Bumps chainlink-common dependency version for integration tests module. |
| integration-tests/go.sum | Updates sums for the bumped chainlink-common version. |
| go.mod | Bumps root module chainlink-common dependency version. |
| go.sum | Updates sums for the bumped chainlink-common version in root module. |
| deployment/go.mod | Bumps chainlink-common dependency version for deployment module. |
| deployment/go.sum | Updates sums for the bumped chainlink-common version. |
| core/scripts/go.mod | Bumps chainlink-common dependency version for core scripts module. |
| core/scripts/go.sum | Updates sums for the bumped chainlink-common version. |
| core/services/workflows/v2/config.go | Introduces and initializes ConfidentialHTTPCalls limiter from settings and closes it. |
| core/services/workflows/v2/capability_executor.go | Adds a limiter mapping entry for confidential-http capability calls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {"evm", "WriteReport"}: limiters.ChainWriteTargets, | ||
| {"http-actions", "SendRequest"}: limiters.HTTPActionCalls, | ||
| {"confidential-http", "SendRequests"}: limiters.HTTPActionCalls, |
Copilot
AI
Feb 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn’t appear to be test coverage asserting that confidential-http calls are bounded by PerWorkflow.ConfidentialHTTP.CallLimit (and not sharing the http-actions limiter). Consider adding a unit/integration test that exercises ExecutionHelper.CallCapability with Id parsing to capName=="confidential-http" and verifies the bound-limiter error once the configured call limit is exceeded.
| {"evm", "FilterLogs"}: limiters.ChainReadCalls, | ||
| {"evm", "WriteReport"}: limiters.ChainWriteTargets, | ||
| {"http-actions", "SendRequest"}: limiters.HTTPActionCalls, | ||
| {"confidential-http", "SendRequests"}: limiters.HTTPActionCalls, |
Copilot
AI
Feb 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The confidential-http capability is still being limited by limiters.HTTPActionCalls, so the newly introduced limiters.ConfidentialHTTPCalls (initialized from cfg.ConfidentialHTTP.CallLimit) is never applied. This means confidential-http calls will share the http-actions budget and changes to ConfidentialHTTP.CallLimit won’t have any effect. Map {"confidential-http", "SendRequests"} to limiters.ConfidentialHTTPCalls instead.
| {"confidential-http", "SendRequests"}: limiters.HTTPActionCalls, | |
| {"confidential-http", "SendRequests"}: limiters.ConfidentialHTTPCalls, |
ecPablo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving go mod changes on deployment/




No description provided.