[CRE-1773] LocalCapabilityManager to launch std caps without job specs#21132
Merged
Conversation
Contributor
CORA - Analysis SkippedReason: The number of code owners (4) is less than the minimum required (5) and/or the number of CODEOWNERS entries with changed files (4) is less than the minimum required (2). |
Contributor
|
I see you updated files related to
|
cedric-cordenier
previously approved these changes
Feb 19, 2026
cedric-cordenier
previously approved these changes
Feb 19, 2026
cedric-cordenier
previously approved these changes
Feb 19, 2026
jmank88
reviewed
Feb 19, 2026
jmank88
reviewed
Feb 19, 2026
jmank88
reviewed
Feb 19, 2026
Comment on lines
+23
to
+24
| func newMetrics() (*metrics, error) { | ||
| meter := beholder.GetMeter() |
Contributor
There was a problem hiding this comment.
WDYT about injecting this to keep things decoupled and more testable?
|
jmank88
approved these changes
Feb 19, 2026
DylanTinianov
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Uh oh!
There was an error while loading. Please reload this page.