return TxReverted from SubmitTransaction when receipt status is 0#21220
Merged
return TxReverted from SubmitTransaction when receipt status is 0#21220
Conversation
Contributor
|
👋 poopoothegorilla, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
poopoothegorilla
force-pushed
the
fix/PLEX-2535
branch
from
a1926ac to
d76c4c4
Compare
|
|
pavel-raykov
previously approved these changes
Feb 18, 2026
dhaidashenko
previously approved these changes
Feb 19, 2026
ilija42
previously approved these changes
Feb 20, 2026
ilija42
dismissed stale reviews from dhaidashenko, pavel-raykov, and themself
via
0071ef6
ilija42
approved these changes
Feb 20, 2026
jmank88
approved these changes
Feb 20, 2026
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EVMService.SubmitTransaction always returned TxSuccess after fetching the transaction receipt, without checking receipt.GetStatus(). When a transaction reverts on-chain (status 0), this caused chain capability DON nodes to return inconsistent results, preventing OCR consensus and producing quorum timeouts.
Check the receipt status after fetching it and return TxReverted when status is 0. Update NewChainReceipt test helper to mock GetStatus() and add a test case verifying reverted receipts produce TxReverted.
Fixes PLEX-2535 https://smartcontract-it.atlassian.net/browse/PLEX-2535