Skip to content

Using numeric(20,0) for chain_selector and blocks in ccv_chain_statuses#21303

Merged
mateusz-sekara merged 1 commit intodevelopfrom
ccv-db-migration-fix
Feb 25, 2026
Merged

Using numeric(20,0) for chain_selector and blocks in ccv_chain_statuses#21303
mateusz-sekara merged 1 commit intodevelopfrom
ccv-db-migration-fix

Conversation

@mateusz-sekara
Copy link
Collaborator

@mateusz-sekara mateusz-sekara requested a review from a team as a code owner February 25, 2026 11:36
Copilot AI review requested due to automatic review settings February 25, 2026 11:36
@mateusz-sekara mateusz-sekara requested a review from a team as a code owner February 25, 2026 11:36
@github-actions
Copy link
Contributor

👋 mateusz-sekara, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the database schema for the ccv_chain_statuses table to use NUMERIC(20,0) instead of TEXT for the chain_selector and finalized_block_height columns. This change aligns with the pattern established in other tables throughout the codebase where uint64 values (like chain selectors) are stored using NUMERIC(20,0).

Changes:

  • Converts chain_selector column from TEXT to NUMERIC(20,0) in ccv_chain_statuses table
  • Converts finalized_block_height column from TEXT to NUMERIC(20,0) in ccv_chain_statuses table
  • Provides proper up and down migration paths with primary key handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cl-sonarqube-production
Copy link

@mateusz-sekara mateusz-sekara added this pull request to the merge queue Feb 25, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2026
@mateusz-sekara mateusz-sekara added this pull request to the merge queue Feb 25, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2026
@mateusz-sekara mateusz-sekara added this pull request to the merge queue Feb 25, 2026
@trunk-io
Copy link

trunk-io bot commented Feb 25, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2026
@mateusz-sekara mateusz-sekara added this pull request to the merge queue Feb 25, 2026
Merged via the queue into develop with commit 11d25cd Feb 25, 2026
219 of 222 checks passed
@mateusz-sekara mateusz-sekara deleted the ccv-db-migration-fix branch February 25, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants