Skip to content

feat: F=0 single-node reliability - persistent cursors, workflow retry, multi-key wiring#21346

Draft
wentzeld wants to merge 2 commits intodevelopfrom
add/zeroF
Draft

feat: F=0 single-node reliability - persistent cursors, workflow retry, multi-key wiring#21346
wentzeld wants to merge 2 commits intodevelopfrom
add/zeroF

Conversation

@wentzeld
Copy link
Contributor

Summary

  • Add persistent trigger cursor store (DB + in-memory) for log event crash recovery
  • Add workflow-level retry with exponential backoff for transient capability errors
  • Wire FromAddresses through write_target to ChainWriterDefinition for multi-key support
  • Fix existing test signatures for updated NewTriggerService

Merge Order

The companion chainlink-evm PR must be merged first. Before merging this PR:

  1. Update the chainlink-evm dependency in go.mod to the merged commit hash
  2. Run go mod tidy
  3. Verify CI passes

Test plan

  • InMemoryCursorStore unit tests (CRUD, independence, overwrite)
  • Retry unit tests (error classification, backoff, context cancellation, exhaustion)
  • Existing log_event_trigger_test.go updated and passing
  • go.mod chainlink-evm hash updated after companion PR merges
  • Full CI green after dependency update

…y, multi-key wiring

  Add reliability hardening for F=0 single-node EVM capability DONs:

  - Persistent trigger cursors: CursorStore interface with DB-backed and
    in-memory implementations for crash recovery of log event triggers
  - Workflow retry: ExecuteWithRetry with exponential backoff and error
    classification (retryable vs non-retryable) for capability execution
  - Multi-key wiring: write_target passes FromAddresses to ChainWriterDefinition
  - Fix log_event_trigger_test.go for updated NewTriggerService signature

  IMPORTANT: The companion chainlink-evm PR must be merged first. After it merges,
  update the chainlink-evm dependency hash in go.mod before merging this PR.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2026

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
* 6 @smartcontractkit/foundations, @smartcontractkit/core
/core/capabilities/ 6 @smartcontractkit/keystone, @smartcontractkit/capabilities-team
/core/services/workflows 3 @smartcontractkit/keystone
/deployment/cre 3 @smartcontractkit/keystone, @smartcontractkit/operations-platform
/deployment/keystone 2 @smartcontractkit/keystone, @smartcontractkit/operations-platform, @smartcontractkit/core
go.mod 4 @smartcontractkit/core, @smartcontractkit/foundations
go.sum 1 @smartcontractkit/core, @smartcontractkit/foundations

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link

trunk-io bot commented Feb 28, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant