[LocalCRE] Launch CRON without a job spec#21389
Conversation
|
👋 bolekk, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
I see you updated files related to
|
|
✅ No conflicts with other open PRs targeting |
![trunk-io[bot]](https://avatars.githubusercontent.com/in/120106?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
There was a problem hiding this comment.
🔴 Test Results: Unrelated Failure
Affected failures:
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_messaging_test.go:Test_CCIPMessaging_Solana2EVM_LOOPP
- Workflow Run: Integration Tests
What Broke
These failures appear to be unrelated to the changes in this PR. One failure in system tests was due to the cron capability not being properly initialized or launched after a logic change. Another failure was a build issue caused by a missing 'lodash' package, indicating a problem with dependency management or the build environment.
Autofix Options
You can use our MCP server to get AI assistance with debugging and fixing these failures.
- Use MCP in your IDE to debug the issue. Try
Help me fix CI failures from s9XKPxPfto get started.
Tip
Get Better Results: This CI job is not uploading test reports. Adding structured test reports enables more precise, test-level analysis with better root cause identification and more targeted fix recommendations.
👉🏻 Learn how to upload test results.
There was a problem hiding this comment.
🔴 Test Results: Local Capability Manager Conflict
Affected failures:
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_messaging_test.go:Test_CCIPMessaging_Solana2EVM_LOOPP
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_token_transfer_test.go:*_LOOPP
What Broke
The introduction and/or incorrect registration of the localcapmgr.NewLocalCapabilityManager service is causing an OCR3 configuration digest mismatch for CCIP plugins. This prevents commit reports and leads to the CCIP messaging system stalling and timing out, indicating a service initialization or lifecycle management issue.
Proposed Fixes
Conditionally set the localCapMgr on the wfLauncher only when the cron-trigger@1.0.0 capability is present in the RegistryBasedLaunchAllowlist to prevent interference with CCIP plugins. Additionally, remove the local capability manager from the application's top-level service list, as its lifecycle is managed by the Workflow Launcher.
In cre.go:420
\t\t\t\treturn nil, fmt.Errorf("could not create local capability manager: %w", lcmErr)
\t\t\t}
+ \t\t\tif localCapMgr != nil {
+ \t\t\t\twfLauncher.SetLocalCapabilityManager(localCapMgr)
+ \t\t\t}
- \t\t\twfLauncher.SetLocalCapabilityManager(localCapMgr)
\t\t\treturn localCapMgr, nil
\t\t}- \t\tif depSvc != nil {
- \t\t\tsrvcs = append(srvcs, depSvc)
- \t\t}Autofix Options
You can apply the proposed fixes directly to your branch. Try the following:
- Comment
/trunk stack-fix 82TOegyWto generate a stacked PR with the proposed fixes. - Use MCP in your IDE to fix the issue. Try
Help me fix CI failures from 82TOegyWto get started.
There was a problem hiding this comment.
🔴 Test Results: Missing Cron Schedule
Affected failures:
- Workflow Run: Integration Tests
What Broke
The removal of cron job setup logic in the cron.go system test file caused integration tests to fail due to missing expected cron job configurations.
Proposed Fixes
Add a default cron schedule configuration to the cron-trigger capability in the PreEnvStartup function, ensuring the capability is properly configured when launched without a job spec.
In cron.go:45
\tdon.AddCapability(flag, &cre.CapabilityConfig{
\t BinaryPath: "cron-trigger",
\t Version: "1.0.0",
+ \t Config: `{"schedule": "0/1 * * * * *"}`,
\t})Autofix Options
You can apply the proposed fixes directly to your branch. Try the following:
- Comment
/trunk stack-fix oOFYjTn3to generate a stacked PR with the proposed fixes. - Use MCP in your IDE to fix the issue. Try
Help me fix CI failures from oOFYjTn3to get started.
Tip
Get Better Results: This CI job is not uploading test reports. Adding structured test reports enables more precise, test-level analysis with better root cause identification and more targeted fix recommendations.
👉🏻 Learn how to upload test results.
| return nil, fmt.Errorf("could not create local capability manager: %w", lcmErr) | ||
| } | ||
| wfLauncher.SetLocalCapabilityManager(localCapMgr) | ||
| srvcs = append(srvcs, localCapMgr) // srvcs is still valid when the callback is called |
There was a problem hiding this comment.
Fixing my silly bug here.
3 participants
[LocalCRE] Launch CRON without a job spec