Skip to content

Cleanup PLEX-1524 stale TODOs#21416

Merged
ilija42 merged 1 commit intodevelopfrom
PLEX-1524-cleanup
Mar 5, 2026
Merged

Cleanup PLEX-1524 stale TODOs#21416
ilija42 merged 1 commit intodevelopfrom
PLEX-1524-cleanup

Conversation

@ilija42
Copy link
Contributor

@ilija42 ilija42 commented Mar 5, 2026

Requires

Supports

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

✅ No conflicts with other open PRs targeting develop

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: LOW. This PR cleans up stale PLEX-1524 TODO comments in the EVM relay service’s transaction submission path, without changing runtime behavior.

Changes:

  • Removed outdated PLEX-1524 TODO comments in SubmitTransaction.
  • Normalized struct literal field alignment (gofmt-style).

You can also share your feedback on Copilot code review. Take the survey.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@trunk-io
Copy link

trunk-io bot commented Mar 5, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestIntegration_LogEventProvider_UpdateConfig The test failed due to errors related to database closure and log poller shutdown during log replay. Logs ↗︎

View Full Report ↗︎Docs

github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2026
@ilija42 ilija42 closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants