Skip to content

llo/channeldefinitions: allow owner to cleanup previously tombstoned channels#21481

Merged
brunotm merged 2 commits intodevelopfrom
bm/llo-channeldefinition-cache-allow-owner-drop-tombstones
Mar 11, 2026
Merged

llo/channeldefinitions: allow owner to cleanup previously tombstoned channels#21481
brunotm merged 2 commits intodevelopfrom
bm/llo-channeldefinition-cache-allow-owner-drop-tombstones

Conversation

@brunotm
Copy link
Collaborator

@brunotm brunotm commented Mar 10, 2026

…channels

Requires

Supports

@github-actions
Copy link
Contributor

👋 brunotm, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

✅ No conflicts with other open PRs targeting develop

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

akuzni2
akuzni2 previously approved these changes Mar 10, 2026
@trunk-io
Copy link

trunk-io bot commented Mar 10, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@brunotm brunotm enabled auto-merge March 10, 2026 21:44

// Drop previously tombstoned channels that the owner has omitted from newDefinitions
// Only tombstoned channels are allowed to be dropped by the owner to eventually remove them from them
// from the OCR state.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"them from" once

@brunotm brunotm added this pull request to the merge queue Mar 11, 2026
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
4.27% Technical Debt Ratio on New Code (required ≤ 4%)

See analysis details on SonarQube

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2026
@brunotm brunotm added this pull request to the merge queue Mar 11, 2026
Merged via the queue into develop with commit a077e93 Mar 11, 2026
219 of 224 checks passed
@brunotm brunotm deleted the bm/llo-channeldefinition-cache-allow-owner-drop-tombstones branch March 11, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants