Skip to content

[CRE-2479] allowlist store#21605

Merged
agparadiso merged 1 commit intodevelopfrom
allowlist_store
Mar 19, 2026
Merged

[CRE-2479] allowlist store#21605
agparadiso merged 1 commit intodevelopfrom
allowlist_store

Conversation

@agparadiso
Copy link
Copy Markdown
Contributor

@agparadiso agparadiso commented Mar 19, 2026

Description

Improve gateway handler
CRE-2479

Requires

Supports

@agparadiso agparadiso requested review from a team as code owners March 19, 2026 12:30
Copilot AI review requested due to automatic review settings March 19, 2026 12:30
@github-actions
Copy link
Copy Markdown
Contributor

👋 agparadiso, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

✅ No conflicts with other open PRs targeting develop

@agparadiso agparadiso enabled auto-merge March 19, 2026 12:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: LOW

This PR updates the on-chain Functions allowlist batching logic to store an immutable snapshot of the in-memory allowlist map after each batch update, avoiding sharing a map that will continue to be mutated across subsequent batches.

Changes:

  • Clone currentAllowedSenderList into a fresh snapshot map before storing it in the atomic pointer.
  • Store the snapshot map pointer instead of the (still-mutating) working map.

@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Mar 19, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@agparadiso agparadiso changed the title allowlist store [CRE-2479] allowlist store Mar 19, 2026
@cl-sonarqube-production
Copy link
Copy Markdown

@agparadiso agparadiso added this pull request to the merge queue Mar 19, 2026
Merged via the queue into develop with commit b36bfaf Mar 19, 2026
218 checks passed
@agparadiso agparadiso deleted the allowlist_store branch March 19, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants