capabilities: fix executable timeout retention regression#21702
Merged
prashantkumar1982 merged 1 commit intodevelopfrom Mar 26, 2026
Merged
capabilities: fix executable timeout retention regression#21702prashantkumar1982 merged 1 commit intodevelopfrom
prashantkumar1982 merged 1 commit intodevelopfrom
Conversation
product-security-plaid-production
bot
requested review from
fernandofederico1984 and
ilija42
Contributor
|
👋 prashantkumar1982, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
|
jmank88
approved these changes
Mar 25, 2026
bolekk
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the timeout/retention regression introduced by PR #21677 and tightens the new tests that came with that change.
What changed
RequestTimeoutwhile still retaining request IDs until the eviction window for dedupeTest_Server_DuplicateRequestRemainsDedupedPastRequestTimeoutrace-safe by synchronizing the noop dispatcher helperEvictableassertions with polling-based checksReview notes
expireRequests()to cancel only when a request became evictable, which delayed timeout responses until the 8 minute retention window elapsed