Skip to content

core/services/workflows: restore and reconfigure Workflow[ExecutionConcurrency]Limits#21779

Merged
jmank88 merged 1 commit intodevelopfrom
CRE-2637-cresettings-wf-vs-execution
Mar 31, 2026
Merged

core/services/workflows: restore and reconfigure Workflow[ExecutionConcurrency]Limits#21779
jmank88 merged 1 commit intodevelopfrom
CRE-2637-cresettings-wf-vs-execution

Conversation

@jmank88
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 commented Mar 30, 2026 •
edited
Loading

https://smartcontract-it.atlassian.net/browse/CRE-2637

The PR proposes stacking all the WorkflowExecutionConcurrency limiters to be enforced where we expect (including an additional PerOrg), and restore the regular WorkflowLimits (although we could just drop them).

Requires:

@jmank88 jmank88 mentioned this pull request Mar 30, 2026
Merged
@jmank88 jmank88 requested review from bolekk and pavel-raykov March 30, 2026 16:53
@jmank88 jmank88 changed the title core/services/workflows: restore and reconfigure Workflow[ExecutionCo… core/services/workflows: restore and reconfigure Workflow[ExecutionConcurrency]Limits Mar 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026 •
edited
Loading

✅ No conflicts with other open PRs targeting develop

jmank88
jmank88 commented Mar 30, 2026
View reviewed changes
Comment thread core/services/workflows/syncerlimiter/limiter.go
Copy link
Copy Markdown
Contributor Author

@jmank88 jmank88 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bolekk Do we still want to have limiters in place for Engine.Init? Or should we trust the limits from upstream, and just run whatever we are told at that point?

Copy link
Copy Markdown
Contributor

@bolekk bolekk Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep it for now (with a high setting). Hopefully once we get a proper queue they will be useful again.

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Mar 30, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@jmank88 jmank88 force-pushed the CRE-2637-cresettings-wf-vs-execution branch 2 times, most recently from 2e56209 to 36b6ed3 Compare March 31, 2026 16:49
@jmank88 jmank88 force-pushed the CRE-2637-cresettings-wf-vs-execution branch from 36b6ed3 to b9e1ec6 Compare March 31, 2026 17:15
@cl-sonarqube-production
Copy link
Copy Markdown

cl-sonarqube-production Bot commented Mar 31, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 marked this pull request as ready for review March 31, 2026 17:38
@jmank88 jmank88 requested review from a team as code owners March 31, 2026 17:38
@jmank88 jmank88 enabled auto-merge March 31, 2026 17:38
@jmank88 jmank88 requested a review from bryan-maxwell March 31, 2026 17:44
bolekk
bolekk approved these changes Mar 31, 2026
View reviewed changes
Comment thread core/services/workflows/syncerlimiter/limiter.go
Copy link
Copy Markdown
Contributor

@bolekk bolekk Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep it for now (with a high setting). Hopefully once we get a proper queue they will be useful again.

Comment thread core/services/workflows/syncerlimiter/limiter.go
cfg.PerOwnerOverrides = normalizeOverrides(cfg.PerOwnerOverrides)

ownerLimit := cresettings.Default.PerOwner.WorkflowExecutionConcurrencyLimit // make a copy
ownerLimit := cresettings.Default.PerOwner.WorkflowLimit // make a copy
Copy link
Copy Markdown
Contributor

@bolekk bolekk Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this already set to a high value in prod? We don't want to push a binary update before that is done.

Copy link
Copy Markdown
Contributor Author

@jmank88 jmank88 Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not set since it was scheduled to be deprecated, and the default is now 1000.

@jmank88 jmank88 added this pull request to the merge queue Mar 31, 2026
Merged via the queue into develop with commit ae46b16 Mar 31, 2026
209 checks passed
@jmank88 jmank88 deleted the CRE-2637-cresettings-wf-vs-execution branch March 31, 2026 18:14
prashantkumar1982 pushed a commit that referenced this pull request Apr 2, 2026
@jmank88
core/services/workflows: restore and reconfigure Workflow[ExecutionCo…
588d4a6 
…ncurrency]Limits (#21779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bolekk bolekk bolekk approved these changes

@pavel-raykov pavel-raykov pavel-raykov approved these changes

@skudasov skudasov Awaiting requested review from skudasov

@bryan-maxwell bryan-maxwell Awaiting requested review from bryan-maxwell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmank88 @bolekk @pavel-raykov